This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
Added custom derivation paths for HD wallets (mnemonic phrase) #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
I changed all paths to derivation paths (instead of address paths), then corrected setHDAddresses(Ledger) functions to reflect it. Used together, it shouldn't break anything. Luckily I have a Ledger and it seems to work ok, addresses are correct and I was able to sign.
You're right, I just assumed the ETH mainnet scenario. I'll get to it tomorrow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first github pull request, so please be gentle :)
I created this commit to enable custom derivation paths. This enables maximum compatibility with existing wallets and standards, as per BIP44 and ethereum/EIPs#84. Any valid BIP39 mnemonic is now accepted.
Under Mnemonic Phrase there is now a radio selection menu:
Select HD derivation path
x m/44'/60'/0'/0 (default)
o m/44'/60'/0' (alternative)
o m/44'/60'/1'/0 (custom)
Path listed as default is currently used by: Jaxx, Metamask, Exodus, imToken, ...
Path listed as alternative is used by: Ledger, Coinomi.
Custom path enables BIP44 multiple accounts, testnet, Ethereum forks, etc... Any BIP32 path should work.