[TASK] Drop atRuleArgs() from the AtRule interface
#1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
task/remove-atruleargs
branch
from
d38a87f to
4f8c137
Compare
The classes implementing this interface use a wide variaty of inconsistent return types when they implement this method. This is a hard blocker for introducing native return type declaration for this method.
oliverklee
force-pushed
the
task/remove-atruleargs
branch
from
4f8c137 to
d40fa16
Compare
JakeQZ
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
I can't think of a better solution which doesn't involve a breaking change.
Most implementations return a string, but CSSNamespace and Import return an array of strings. Changing one or other to match would be a breaking change, since they are part of the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes implementing this interface use a wide variaty of inconsistent return types when they implement this method.
This is a hard blocker for introducing native return type declaration for this method.