Skip to content

[BUGFIX] Use the safe regexp functions in CSSList #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025
Merged

[BUGFIX] Use the safe regexp functions in CSSList #1368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ded6d8
[BUGFIX] Use the safe regexp functions in `CSSList`
oliverklee Aug 21, 2025
e4e4044
`use` it
oliverklee Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ Please also have a look at our

### Fixed

- Use typesafe versions of PHP functions (#1368)

### Documentation

## 9.0.0: New features, deprecation removals and bug fixes
Expand Down
4 changes: 3 additions & 1 deletion src/CSSList/CSSList.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
use Sabberworm\CSS\Value\URL;
use Sabberworm\CSS\Value\Value;

use function Safe\preg_match;

/**
* This is the most generic container available. It can contain `DeclarationBlock`s (rule sets with a selector),
* `RuleSet`s as well as other `CSSList` objects.
Expand Down Expand Up @@ -242,7 +244,7 @@ private static function identifierIs(string $identifier, string $match): bool
return true;
}

return \preg_match("/^(-\\w+-)?$match$/i", $identifier) === 1;
return preg_match("/^(-\\w+-)?$match$/i", $identifier) === 1;
}

/**
Expand Down