Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tripal eutils.module.fix #229

Merged
merged 6 commits into from
Feb 9, 2021
Merged

Conversation

dsenalik
Copy link
Collaborator

Pull request for Issue #228

The missing parameter (an empty array) is added to the call to tripal_report_error()

@dsenalik
Copy link
Collaborator Author

Sorry for the mess of commits, there is only one small change actually made

@dsenalik
Copy link
Collaborator Author

I added a second change to define a default assembly method is none was specified, needed because there is a NOT NULL constraint on the program and programversion columns in the chado.analysis table.
This problem showed up on NCBI assembly GCA_902728035.1 which is what triggered my discovery of the first error.

@mpoelchau
Copy link
Contributor

Thanks @dsenalik, I think the placeholder text that you added is good. The next question would be how to work with NCBI and the submitters to add a method, but that's out of scope of this module...

Thanks for submitting the PR!

@dsenalik
Copy link
Collaborator Author

dsenalik commented Jan 27, 2021

Check has failed on a request to NCBI. I am occasionally getting timeouts locally on requests to NCBI. Maybe we can rerun the checks again later?

  1. Tests\EUtilsTest::testConvertingAccession with data set flexibly parsing attributes, child values, child attributes, while dealing with key name overlap #5 ('biosample', 'SAMN02981385', '2981385')
    Exception: ERROR Could not make request: Status: 400

@Ferrisx4 Ferrisx4 merged commit 382bcbc into NAL-i5K:master Feb 9, 2021
@dsenalik dsenalik deleted the tripal_eutils.module.fix branch February 9, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants