Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Issue related_merge_requests endpoint #683

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

ddavison
Copy link
Contributor

@ddavison ddavison commented Feb 9, 2024

$ rake rubocop
Offenses:

lib/gitlab/cli_helpers.rb:23:48: C: [Correctable] Style/RedundantParentheses: Don't use parentheses around a logical expression.
      @client ||= Gitlab::Client.new(endpoint: (Gitlab.endpoint || ''))
                                               ^^^^^^^^^^^^^^^^^^^^^^^

165 files inspected, 1 offense detected, 1 offense autocorrectable
RuboCop failed!

@ddavison
Copy link
Contributor Author

ddavison commented Feb 9, 2024

This is an upstream fix, after this comment was spotted.

Fix outstanding rubocop issue in cli_helpers
Fix actions; use different ruby jobs
@ddavison ddavison force-pushed the dj-add-related-merge-requests branch from b0f2179 to 202c06d Compare February 9, 2024 17:10
@ddavison
Copy link
Contributor Author

ddavison commented Feb 9, 2024

@NARKOZ — This one is ready for review! 🙏

Also, it looks like the Actions was having an issue with the Ruby/Bundle versioning (example of that from #680). This PR should fix that workflow.

@NARKOZ NARKOZ merged commit 79c6759 into NARKOZ:master Apr 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants