Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition campaign map to GL JS #134

Merged
merged 11 commits into from
Sep 30, 2020
Merged

Transition campaign map to GL JS #134

merged 11 commits into from
Sep 30, 2020

Conversation

necoline
Copy link
Contributor

Changing background image to use mapbox

Todo:

  • The styles url needs authentication
  • add bounding box
  • zoom level dynamically set to be above bounding box
  • orient map to show bounding box on right hand side
  • add header text
  • test ssr - mapbox use of updating window can make for a finicky experience

@necoline necoline requested a review from AliceR September 26, 2020 17:42
Copy link
Member

@AliceR AliceR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start 🙌
Left some thoughts below.

},
})
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is happening here, and why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to resolve issues arising from mapbox's use of window
gatsbyjs/gatsby#6667
https://www.gatsbyjs.com/docs/debugging-html-builds/#fixing-third-party-modules

I'm not sure if we actually need this though. I need to resolve a few other error that show up in the build before I can test this out

@AliceR AliceR changed the title Fix/header image Transition campaign map to GL JS Sep 28, 2020
@AliceR AliceR marked this pull request as ready for review September 29, 2020 12:37
@necoline necoline merged commit 7066e8a into develop Sep 30, 2020
@necoline necoline deleted the fix/header-image branch September 30, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants