Add row count check to spot check data

[jordanpadams]

Make sure we are not trying to read a record beyond the defined row count for the product file.

Resolves #554

⚙️ Test Data and/or Report

https://github.com/NASA-PDS/validate/actions/runs/3670637715

[nutjob4life]

👍

[al-niessner]

There are two problems that persist with this fix.

1. this.currentTableReader is instantiated once but this.currentTableReader.readNext() is called from many functions in this class. Therefore you cannot know where readNext() is pointing without a reset back to the beginning.
2. If next the reader is giving valid record (not null) past end of table, then that is really an error in the reader.

I guess me be slow allowed this symptomatic fix to be merged.

[jordanpadams]

@al-niessner great points.

1. this.currentTableReader is instantiated once but this.currentTableReader.readNext() is called from many functions in this class. Therefore you cannot know where readNext() is pointing without a reset back to the beginning.

agreed. this is really a problem with the overall architecture of the code. I am pretty sure if you roll up where those readNext() calls are happening, only one of those can be executed depending upon the type of product being validated. more clear encapsulation would probably help here.

2. If next the reader is giving valid record (not null) past end of table, then that is really an error in the reader.

the reader was throwing an IOException because we were trying to read too far. that being said, we actually have a feature request to actually try to "peak" past the defined table to see if the definition is invalid (e.g. label defines table with 5 records, but the products actually has 10 records)