Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#474: Fix issue with validate not properly traversing directories #579

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

When reworked this class a month ago, did not propagate the full path so error reflected what was happening but not what was being asked to happen. Propagated the directories all the way to the handle().

⚙️ Test Data and/or Report

CLI: validate document_rise\ -R pds4.folder -r validate_report.txt

validate_report.txt:

PDS Validate Tool Report

Configuration:
   Version                       3.1.0-SNAPSHOT
   Date                          2022-12-21T20:46:04Z

Parameters:
   Targets                       [file:/tmp/document_rise/]
   Rule Type                     pds4.folder
   Severity Level                WARNING
   Recurse Directories           true
   File Filters Used             [*.xml, *.XML]
   Data Content Validation       on
   Product Level Validation      on
   Max Errors                    100000
   Registered Contexts File      /home/niessner/Projects/PDS/validate/src/main/resources/util/registered_context_products.json



Product Level Validation Results

  PASS: file:/tmp/document_rise/RISE_InSight_SIS_Raw.xml
        1 product validation(s) completed

Summary:

  0 error(s)
  0 warning(s)

  Product Validation Summary:
    1          product(s) passed
    0          product(s) failed
    0          product(s) skipped

  Referential Integrity Check Summary:
    0          check(s) passed
    0          check(s) failed
    0          check(s) skipped


End of Report

♻️ Related Issues

#474

@al-niessner al-niessner requested a review from a team as a code owner December 21, 2022 20:55
@al-niessner al-niessner self-assigned this Dec 21, 2022
@al-niessner
Copy link
Contributor Author

@jordanpadams ready for review

In general who all should I include for reviews? Who is the new responsible engineer?

@jordanpadams
Copy link
Member

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems innocuous enough! 👍

@jordanpadams jordanpadams merged commit 8a4b675 into main Dec 22, 2022
@jordanpadams jordanpadams deleted the issue_474 branch December 22, 2022 19:35
@jordanpadams jordanpadams changed the title not propagating dirs #474: Fix issue with validate not properly traversing directories Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants