Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 531: add testing #584

Merged
merged 1 commit into from
Dec 30, 2022
Merged

issue 531: add testing #584

merged 1 commit into from
Dec 30, 2022

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

These are the shorter (smaller) test XML and data file from Archive.zip in the ticket. It was moved to success and then replicated with a change to repetition in fail. They behave correctly with changes in NASA-PDS/pds4-jparser#81

⚙️ Test Data and/or Report

♻️ Related Issues

#531

@al-niessner al-niessner requested a review from a team as a code owner December 29, 2022 18:54
@al-niessner al-niessner self-assigned this Dec 29, 2022
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too cool for school

@jordanpadams
Copy link
Member

Re-ran tests after merging NASA-PDS/pds4-jparser#81 and all checks out

🚀

@jordanpadams jordanpadams merged commit b44bdf7 into main Dec 30, 2022
@jordanpadams jordanpadams deleted the issue_531 branch December 30, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants