remove context product name case sensitivity check #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2023 10:39
This unit test may not work because the change is to an INFO and not an error or warning and therefore has no summary. In other words, cucumber tests were not built to handle this situation.
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
nutjob4life
approved these changes
May 10, 2023
There was a problem hiding this comment.
TIL what :: does in Java. Shows you how often I program in Java. Thanks for the lesson @al-niessner!
Changes approved.
jordanpadams
approved these changes
May 11, 2023
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Removed the checks that verified that the item case was different between input and registered values.
⚙️ Test Data and/or Report
See #631 for original output. Here is new output as I think unit test is insufficient.
♻️ Related Issues
Closes #631