Detect duplicate lidvids in bundle/collection inventories #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
added 4 commits
May 17, 2023 10:50
Changed names and check location to base it on ProductType instead of by table type since bundles do not use the inventory table to identify their references.
jordanpadams
approved these changes
May 19, 2023
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Checks for duplicate lid/lidvid values in the collection inventory file or bundle bundle_member_entry.
⚙️ Test Data and/or Report
See unit tests below
♻️ Related Issues
#476