Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

674: add integer types to array processing #676

Merged
merged 1 commit into from
Aug 4, 2023
Merged

674: add integer types to array processing #676

merged 1 commit into from
Aug 4, 2023

Conversation

al-niessner
Copy link
Contributor

@al-niessner al-niessner commented Aug 3, 2023

🗒️ Summary

While floats and decimals were converted to BigInt the integer types where not. Added them.

⚙️ Test Data and/or Report

Test files given are too large for git (see #659) plus it 5 minutes but here is the output from run:

Product Level Validation Results

  PASS: file:/home/niessner/Projects/PDS/validate/src/test/resources/github674/M1433566422LC.xml
        1 product validation(s) completed
Aug 03, 2023 3:39:32 PM gov.nasa.pds.tools.validate.task.ValidationTask execute
INFO: Validation complete for location 'file:/home/niessner/Projects/PDS/validate/src/test/resources/github674/M1433566422LC.xml'

Summary:

  0 error(s)
  0 warning(s)

  Product Validation Summary:
    1          product(s) passed
    0          product(s) failed
    0          product(s) skipped

  Referential Integrity Check Summary:
    0          check(s) passed
    0          check(s) failed
    0          check(s) skipped


End of Report
Completed execution in 266455 ms

♻️ Related Issues

Closes #674

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Aug 3, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@jordanpadams jordanpadams merged commit 2edb8b1 into main Aug 4, 2023
2 checks passed
@jordanpadams jordanpadams deleted the issue_674 branch August 4, 2023 18:40
@al-niessner
Copy link
Contributor Author

@jordanpadams

This is merged. Why is it in the zenhub todo list for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate does not handle special constants with data type of SignedLSB2
2 participants