Check that files with label extension are actually labels to avoid errors on floating XML files #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
nutjob4life
requested changes
Aug 23, 2023
nutjob4life
approved these changes
Aug 23, 2023
jordanpadams
approved these changes
Aug 23, 2023
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Add a check that files that have the label extension really are labels and remove them from the target list if they are not preventing lots of SAX parsing exceptions. Files that are "floating" like this show up as un-referenced warnings by the bundle or collection. If given as the target, it will still blow up making it obvious to the user.
⚙️ Test Data and/or Report
See automate unit tests below (specifically 482).
♻️ Related Issues
Closes #679