Upgrade net.sf.saxon:Saxon-HE from 9.9.1-7 to 12.3 #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warnings are gone. Loading of schematron failures are still there. Run it by hand and it works fine. Has to be something with the site not liking 10000 downloads all at once from the same location. Anyway, ready for review. |
|
These intermittent network outages when trying to run validate tests is very concerning... but will merge this for now. |
jordanpadams
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
The new SAXON libraries are more pedantic about processing XML files. It now generates warning and errors that cannot be squashed - well I could not find the wire to cut to the blinking red light. Instead, changed validate so that it would not ask SAXON to parse files that do not have the XML extension given by the user or defined by default.
⚙️ Test Data and/or Report
All automated unit tests should pass
♻️ Related Issues
Closes #707
Closes #726