Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plurality in JSON report header to make it consistent with other styles #835

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

cgobat
Copy link
Contributor

@cgobat cgobat commented Feb 21, 2024

🗒️ Summary

Removes the s from "configurations" so that the JSON report header keys match the tags in the XML style (see line 150 of XmlReport.java) and the section titles in the "full" report (see line 168 of FullReport.java).

⚙️ Test Data and/or Report

Given the extremely simple nature of this PR (see Files changed), I did not bother setting up a local testing environment. Hopefully that is okay in this case, but let me know if it's needed.

♻️ Related Issues

#827 (comment)

@cgobat cgobat requested a review from a team as a code owner February 21, 2024 23:36
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks safe!

@al-niessner al-niessner self-requested a review February 21, 2024 23:45
Copy link
Contributor

@al-niessner al-niessner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix.

@jordanpadams jordanpadams merged commit 041f0b8 into NASA-PDS:main Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants