-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ufs_public_release: update version number and authors, bugfix for samfdeepcnv.f, update of scientific documentation #374
Merged
climbfuji
merged 13 commits into
NCAR:ufs_public_release
from
climbfuji:update_version_number_and_authors
Jan 10, 2020
Merged
ufs_public_release: update version number and authors, bugfix for samfdeepcnv.f, update of scientific documentation #374
climbfuji
merged 13 commits into
NCAR:ufs_public_release
from
climbfuji:update_version_number_and_authors
Jan 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
climbfuji
commented
Dec 26, 2019
•
edited
Loading
edited
- update version number from 3.0.0 to 4.0.0
- update author list in CMakeLists.txt
- bugfix for samfdeepcnv.f to prevent crash when regression tests are run in DEBUG mode (use of uninitialized variables)
- contains @mzhangw's update of the scientific documentation (Scientific documentation v4.0 for UFS public release #376)
- note: I created a baseline before pulling in the scientific documentation changes and then verified that the code reproduced this baseline after pulling in the scientific documentation
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
December 26, 2019 22:34
…cpp-physics into doc4ufs_public_release
…s, leads to crashes in debug mode
climbfuji
changed the title
ufs_public_release: update version number and authors
ufs_public_release: update version number and authors, bugfix for samfdeepcnv.f
Jan 7, 2020
Should the updates to the SciDoc be included in this PR or be submitted as a separate PR? |
Separate, please. |
Thanks. The Sci Doc update is in PR
#376.
…On Tue, Jan 7, 2020 at 3:23 PM Dom Heinzeller ***@***.***> wrote:
Separate, please.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#374?email_source=notifications&email_token=AE7WQATHAZBP542FGOHO3U3Q4T6FNA5CNFSM4J7RGGLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIKP2SY#issuecomment-571800907>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7WQARETLDLPQ6CYNEVQ7DQ4T6FNANCNFSM4J7RGGLA>
.
|
llpcarson
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
…cpp-physics into update_version_number_and_authors
climbfuji
changed the title
ufs_public_release: update version number and authors, bugfix for samfdeepcnv.f
ufs_public_release: update version number and authors, bugfix for samfdeepcnv.f, update of scientific documentation
Jan 9, 2020
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
* io/FV3GFS_io.F90 updated to use fms2_io * atmos_model.F90 and ccpp/data/GFS_typefs.F90 updates to input_nml_file handling * atmos_cubed_sphere submodule updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.