Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw centering info on individual camera images #359

Closed
6 tasks done
mgalloy opened this issue Nov 1, 2023 · 17 comments
Closed
6 tasks done

Draw centering info on individual camera images #359

mgalloy opened this issue Nov 1, 2023 · 17 comments
Assignees
Labels
enhancement new feature needs testing needs more testing/verification
Milestone

Comments

@mgalloy
Copy link
Member

mgalloy commented Nov 1, 2023

Use 20210703 as test data.

Tasks

For quicklooks:

  • do not 'fill' the occulter when you draw the circle at the occulter
  • change circle drawn around occulter to green
  • the '+' sign in the center of occulter is using the array center, but should use the occulter center

For level 2 UNMASKED GIFS (produced about every 20 minutes):

  • draw a circle at the height of the occulter in the color green (do not use the /FILL option)

For level 1 unmasked GIFs (produced about every 20 minutes):

  • create unmasked GIF per camera with centering annotations at the same cadence as the other unmasked GIFs

Questions

  • This is done on the realtime quicklooks in the level0/quicklooks directory. Is this sufficient or should there be an option to produce annotated level 1 or 2 quicklooks? No, need specific changes from @jburkepile.
@mgalloy mgalloy added the enhancement new feature label Nov 1, 2023
@mgalloy mgalloy added this to the 2.2 reprocessing milestone Nov 1, 2023
@mgalloy mgalloy self-assigned this Nov 1, 2023
@mgalloy mgalloy added the questions coding is stoppped to determine correct path label Dec 6, 2023
@jburkepile
Copy link
Collaborator

jburkepile commented Dec 13, 2023

The level0 quicklooks have a circle drawn at the location of the photosphere based on the center found for the occulter.

  • Please add another circle to locate the outer edge of the occulter; you may need to make that circle red.
  • The level 0 quicklooks have a green '+' at a fixed position (array center?). This is most obvious when you toggle the first and last quicklook gif of the day. Can you put the '+' at the occulter center?
  • Please draw a circle at the height of the occulter in the Level 2 nomasked gifs. You create an nomask level 2 gif about every 15 minutes.

@mgalloy
Copy link
Member Author

mgalloy commented Dec 13, 2023

@bberkeyU, below are examples of the gallery and normal quicklooks. I am going to get rid of the grey mask under the occulter for the normal quicklooks — do you want that for the gallery quicklooks also?

Gallery quicklook:

20221007_174535_kcor_cam0_gallery_g

Normal level 0 quicklook:

20221007_174535_kcor_cam0_g

@mgalloy
Copy link
Member Author

mgalloy commented Dec 13, 2023

@bberkeyU is OK with the same as normal quicklooks.

@mgalloy
Copy link
Member Author

mgalloy commented Dec 14, 2023

Here are the updated level 0 quicklooks:

20221007_174535_kcor_cam0_gallery_g

20221007_174535_kcor_cam0_g

@jburkepile
Copy link
Collaborator

Thanks for making these. The data are still masked. You are applying a mask in the quicklook code so it is tough to determine if the green circle is located at the occulter edge.

To verify the level 1 pipeline centers we could save unmasked 'level1' gifs from each camera with a circle drawn at the occulter, before you shift, rotate and combine the two cameras. That would provide the center found for the calibrated images. We can talk about that to make sure its worth it.
Thanks again!

@mgalloy
Copy link
Member Author

mgalloy commented Dec 14, 2023

Below are the quicklooks without masking. Note that not masking changes the display scaling of the GIF because we take the display maximum from the maximum value in the array. Should we scale according to the max value in the masked version?

20221007_174535_kcor_cam0_gallery_g

20221007_174535_kcor_cam0_g

@jburkepile
Copy link
Collaborator

Wow Mike! That was incredibly fast. The unmasked are much better for assessing the accuracy of the occulter size found by the code. I like your idea to use the masked scaling on the unmasked gif. That's the best of both worlds.

Thanks so much!

@mgalloy
Copy link
Member Author

mgalloy commented Dec 14, 2023

Here are the new unmasked quicklooks scaled from the masked pB.

20221007_174535_kcor_cam0_gallery_g

20221007_174535_kcor_cam0_g

@mgalloy
Copy link
Member Author

mgalloy commented Dec 15, 2023

Here is the updated nomask GIF:

20221007_171731_kcor_l2_nomask

@mgalloy
Copy link
Member Author

mgalloy commented Dec 15, 2023

Full results are in raw.latest/20221007.

mgalloy added a commit that referenced this issue Dec 15, 2023
@mgalloy mgalloy removed the questions coding is stoppped to determine correct path label Dec 22, 2023
@detoma
Copy link
Contributor

detoma commented Dec 28, 2023

I am not sure you can use level 2 polarization data to estimate the goodness of the radius. There is too much done to the level2 data. I would go back to Stoke I and do it for the two cameras separately.

@jburkepile
Copy link
Collaborator

Giuliana: You make a good point. Mike measures the radius in the level 1 pB (after distortion, etc. ) Mike also saves the level 1 intensity image. He can measure the radius of the intensity mage along with the pB image for comparison Thanks very much for pointing that out.

@mgalloy
Copy link
Member Author

mgalloy commented Jun 25, 2024

I have a test run in raw.latest for 20240409 with the new level 1 nomask GIFs.

@mgalloy mgalloy added the needs testing needs more testing/verification label Jun 25, 2024
@mgalloy
Copy link
Member Author

mgalloy commented Jul 2, 2024

I was sending the same image into each GIF creation, so getting camera 0 image for both level 1 nomask GIFs.

Also, need to put logic in for making the level 1 nomask GIFs at the same cadence as the regular nomask GIFs, not for every level 1 file.

mgalloy added a commit that referenced this issue Jul 2, 2024
- Produce level 1 nomask images at the normal cadence in the eod
- Use the distortion corrected radius
- Use the correct camera 0 or 1 image for each GIF
@mgalloy
Copy link
Member Author

mgalloy commented Jul 5, 2024

The first nomask image (for each camera) is showing green in the saturated areas and annotations, as well as the occulter circle.

  • Only the first camera 0 and camera 1 nomask images have the extra green.
  • The color table in the GIF is correct. Only color 255 is green.
  • The value in the saturated areas of the GIF is 255.
  • The annotations appear green as well.
  • When I run the code outside of the pipeline, no extra green is produced.

@jburkepile
Copy link
Collaborator

jburkepile commented Jul 9, 2024

Mike. Please create cam0 and cam1 unmasked images (FITS/GIFs) with circles in the GIFs for these dates:

  • June 18, 2015
  • June 22 2015
  • June 23, 2015
  • Oct 30, 2017
  • Nov 1, 2017
  • Nov 2, 2017
  • Dec 16, 2019
  • Dec 17, 2019

I need to look at the individual cameras with the circles for these dates to assess the changes in measured occulter radii that may indicate a platescale change. I will note this in ticket #367 where we are studying that issue.

@mgalloy
Copy link
Member Author

mgalloy commented Jul 11, 2024

I forgot to mention that the test dates above are done, and the results are in raw.draw_circle. The green color on saturated values is fixed, so this issue can be closed if those test dates are good.

@mgalloy mgalloy closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature needs testing needs more testing/verification
Projects
None yet
Development

No branches or pull requests

3 participants