Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del_properties methods, and ignore_properties keyword to cf.unique_constructs #598

Merged
merged 12 commits into from
Mar 1, 2023

Conversation

davidhassell
Copy link
Collaborator

@davidhassell davidhassell commented Feb 14, 2023

Fixes #597

This is mainly inheriting work from cfdm: NCAS-CMS/cfdm#241 (Edit 2023-03-01: now merged)

Items of note:

  • Deletes the unused cf/abstract/constructlist.py
  • Improves a few docstrings
  • Updates a load of .rst files for the new method

@davidhassell davidhassell added this to the Next release milestone Feb 14, 2023
@davidhassell
Copy link
Collaborator Author

Hi @sadielbartholomew - I think I have to go ahead and merge this for timely "CANARI" purposes. Happy to revisit later ...

@davidhassell davidhassell merged commit 7b9e6b3 into NCAS-CMS:main Mar 1, 2023
@sadielbartholomew
Copy link
Member

Hi David, fair enough - sorry I did't get a chance to review it around the SIAM CSE23 conference prep and participation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New ignore_properties keyword to cf.unique_constructs
2 participants