Сделал начальный и средний уровень #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-kborovik
requested changes
Oct 27, 2022
Comment on lines
+147
to
+153
| var customers = await ProductAndCustomerService.GetCustomersAsync(); | ||
| customers.RemoveAt(index); | ||
|
|
||
| using (FileStream fs = new FileStream("StaticFiles/Customers.json", FileMode.Truncate)) | ||
| { | ||
| await JsonSerializer.SerializeAsync<List<CustomerModel>>(fs, customers); | ||
| } |
There was a problem hiding this comment.
а почему ты это не вынес в ProductAndCustomerService?
There was a problem hiding this comment.
Делал немного в спешке, переделаю
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Сделал начальный и средний уровень без проверок на вводимые данные при добавлении элементов в сущности. Не знаю, когда смогу доделать, поэтому решил скинуть пока что есть на проверку, на неделе доделаю и долью.