Skip to content

Conversation

tbauriedel
Copy link
Member

  • Add possibility to disable user/role creation in logstash
  • I have also renamed the var logstash_user to logstash_user_name to have the same schema as for logstash_role_name

Implemented for #320

@tbauriedel tbauriedel added the feature New feature or request label Jun 10, 2024
@tbauriedel tbauriedel requested a review from widhalmt June 10, 2024 09:44
@tbauriedel tbauriedel self-assigned this Jun 10, 2024
Copy link
Member

@widhalmt widhalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. I just think you mixed up the order of words in your variables name. See suggestions for details.

tbauriedel and others added 2 commits June 10, 2024 13:03
Co-authored-by: Thomas Widhalm <thomas.widhalm@netways.de>
Co-authored-by: Thomas Widhalm <thomas.widhalm@netways.de>
@tbauriedel tbauriedel requested a review from widhalmt June 10, 2024 11:03
Copy link
Member

@widhalmt widhalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Go for it.

@tbauriedel tbauriedel added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit 4797699 Jun 10, 2024
@tbauriedel tbauriedel deleted the feature/selectable-user-creation branch June 10, 2024 14:13
ivareri pushed a commit to ivareri/ansible-collection-elasticstack that referenced this pull request Jun 17, 2025
* Add possibility to disable user/role creation in logstash
* I have also renamed the var `logstash_user` to `logstash_user_name` to
have the same schema as for `logstash_role_name`

Implemented for NETWAYS#320

---------

Co-authored-by: Thomas Widhalm <thomas.widhalm@netways.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants