Lint full codebase before merging #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea of this PR is:
I'm still struggling a bit with GitHub's Action syntax. |
|
It looks like the tests for changes in roles only run once when a push to their code is made. They don't run, when the PR will change them. Seems like I just learned the difference between the I'm not sure which trigger I like better. Any opinions? |
widhalmt
added a commit
that referenced
this pull request
Feb 16, 2023
Needs #88 to be merged into this branch
Merged
widhalmt
requested review from
mkayontour
and removed request for
mkayontour
mkayontour
previously approved these changes
Feb 16, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Since some checks will only run when adding the PR to the queue, we need a quick approve, even when the approver didn't have time to dig into the code as a whole. This is an exception, hopefully and applies to all approves after this comment. |
mocdaniel
approved these changes
Feb 16, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
widhalmt
added a commit
that referenced
this pull request
Feb 20, 2023
* Fix some lint Needs #88 to be merged into this branch * Fix triggers for actions * Improve idempotency
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
* Fix metadata lint fixes NETWAYS#88 * Convert versions into strings * Add missing namespace * Add missing Debian support * Fix naming convention for tasks
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
* Fire handlers after starting Elasticsearch * Wait for all instances instead of only one * Disable https in no-security checks * Remove connection check from single node scenario * Change URL to new home of roles * Rename instances to avoid collisions * Remove v8 for now and run unparalleled fixes NETWAYS#88
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
* Lint full codebase before merging * Make a full stack test for every pr against main * Test merge to full against all supported OS fixes NETWAYS#17 * fix lint * Typo * Rename jobs * Run mandatory checks on queueing * Run mandatory checks with every PR and queue
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
* Fix some lint Needs NETWAYS#88 to be merged into this branch * Fix triggers for actions * Improve idempotency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this mostly to test mandatory status checks