Skip to content

Add new netdev option to allow unknown state in interfaces #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024

Conversation

RincewindsHat
Copy link
Member

No description provided.

Copy link
Member

@martialblog martialblog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start adding tests, the code is getting more and more complex.

Maybe refactor some larger functions into smaller ones that can be tested more easily

@RincewindsHat
Copy link
Member Author

In general I do agree. Although I feel like this change does not require specific testing.

@RincewindsHat RincewindsHat merged commit 1cd33ca into main May 8, 2024
@RincewindsHat RincewindsHat deleted the interface_unknown_is_ok branch May 8, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants