-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:page-header): new pageheader style and support avatar #4208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4208 +/- ##
==========================================
+ Coverage 92.31% 92.33% +0.02%
==========================================
Files 519 520 +1
Lines 10963 10965 +2
Branches 1984 1984
==========================================
+ Hits 10120 10125 +5
+ Misses 420 418 -2
+ Partials 423 422 -1
Continue to review full report at Codecov.
|
Deploy preview for ng-zorro-master ready! Built with commit b59877f |
a22ab34
to
e833b70
Compare
1d956e9
to
b59877f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
]; | ||
|
||
@NgModule({ | ||
imports: [CommonModule, NzAddOnModule, NzIconModule, NzDividerModule], | ||
exports: [NzPageHeaderComponent, ...NzPageHeaderCells], | ||
declarations: [NzPageHeaderComponent, ...NzPageHeaderCells] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank, we have found the breakchange in styles, we will fix it in the next version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information