Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:affix): set correct style of Affix after trigger resize #3089

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

zd5043039119
Copy link
Contributor

@zd5043039119 zd5043039119 commented Mar 14, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3040

What is the new behavior?

After triggering the resize event, the Affix element will not lose height and behave normally.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 14, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 150dcb2

https://deploy-preview-3089--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #3089 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3089      +/-   ##
==========================================
+ Coverage   97.32%   97.32%   +<.01%     
==========================================
  Files         550      550              
  Lines       11513    11514       +1     
  Branches      820      820              
==========================================
+ Hits        11205    11206       +1     
  Misses        199      199              
  Partials      109      109
Impacted Files Coverage Δ
components/affix/nz-affix.component.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a06cf...150dcb2. Read the comment docs.

@cipchk cipchk self-requested a review March 17, 2019 11:45
Copy link
Member

@cipchk cipchk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants