fix: broken logic in setting and determining the current selected option #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tts-fe-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thePeras
reviewed
Sep 2, 2024
tomaspalma
force-pushed
the
fix/reorder-options-not-working
branch
from
8981815 to
44fb167
Compare
thePeras
approved these changes
Sep 2, 2024
…correct selected option logic
thePeras
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We access the multiple options current option by
multipleOptions[selectedOption]which makes the previous logic prior to this PR broken.Before the
selectedOptionwould have the value of theoption.idthat we clicked instead of its position in the array, which was causing issues.Besides, the logic for checking whether or not an option was selected was broken and was comparing the option ids , instead of what it's done now that is comparing correctly the index of the array