This repository was archived by the owner on Nov 25, 2020. It is now read-only.
Added Kadane Algo #103
Merged
Added Kadane Algo #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kadane/kadane.cpp
Outdated
| for(int i = 0; i < size; i++) | ||
| { | ||
| //Iterate over Array adding each element to current max | ||
| currentMax = currentMax + arr[i]; |
There was a problem hiding this comment.
wrong declaration of variable
Kadane/kadane.cpp
Outdated
|
|
||
| //finalMax updated when less than currentMax | ||
| if(finalMax < currentMax) | ||
| finalMax = currentMax; |
There was a problem hiding this comment.
same. This type of method is used in functions
| @@ -0,0 +1,46 @@ | |||
| //MAXIMUM SUM OF SUBARRAY(CONTIGUOUS SUBSEQUENCE) KADANE'S ALGO | |||
|
|
|||
|
The algorithm doesn't run properly in the first place |
|
I've added the Sample input/output and done the snake casing of variable names and camel casing of function name. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100