Skip to content

Inefficient handling of 'limit' #126

@caveadventure

Description

@caveadventure

A query like select day,count(*) from index where x = query('FreeBSD') group by day limit 200 generates an Elasticsearch query like this:

{
  "from" : 0,
  "size" : 200,
  "query" : {
    "bool" : {
      "must" : {
        "query_string" : {
          "query" : "FreeBSD"
        }
      }
    }
  },
  "_source" : {
    "includes" : [ "day", "COUNT" ],
    "excludes" : [ ]
  },
  "fields" : "day",
  "aggregations" : {
    "day" : {
      "terms" : {
        "field" : "day",
        "size" : 200
      },
      "aggregations" : {
        "COUNT(*)" : {
          "value_count" : {
            "field" : "_index"
          }
        }
      }
    }
  }
}

Testing shows that the first top-level "size": 200 is unnecessary and results in much slower queries. It should probably be set to "size": 0 since the hits aren't needed anyways when doing aggregations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions