Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogBeginScopeParser - Refactoring and improved exception handling #289

Merged
merged 3 commits into from
May 28, 2019

Conversation

snakefoot
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #289 into master will increase coverage by 0.03%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   73.84%   73.88%   +0.03%     
==========================================
  Files          12       12              
  Lines        1086     1076      -10     
  Branches      190      191       +1     
==========================================
- Hits          802      795       -7     
+ Misses        220      219       -1     
+ Partials       64       62       -2
Impacted Files Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 80.95% <0%> (-0.6%) ⬇️
...Extensions.Logging/Logging/NLogBeginScopeParser.cs 65.75% <77.77%> (+1.27%) ⬆️
...ensions.Logging/Config/NLogLoggingConfiguration.cs 93.93% <97.14%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931cfbe...8ee4067. Read the comment docs.

@304NotModified
Copy link
Member

@snakefoot
Copy link
Contributor Author

Have bumped the version to 1.5.1-rc1

@304NotModified 304NotModified self-assigned this May 7, 2019
@snakefoot snakefoot force-pushed the master branch 3 times, most recently from 18869a8 to 7642e72 Compare May 17, 2019 16:02
…tion without it suddenly no longer including Default-wrapper or Default-target-parameters
@304NotModified 304NotModified merged commit def8dcb into NLog:master May 28, 2019
@304NotModified
Copy link
Member

finally merged :)

@snakefoot
Copy link
Contributor Author

Created #299 for you also :)

@304NotModified
Copy link
Member

approved. Should merge automatically :)

@304NotModified 304NotModified added this to the 1.5.1 milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants