-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next runcards update #295
Next runcards update #295
Conversation
I was not planning to write an "actual" jets runner in EKO ever. But if needed I can contribute the utilities for batching to Pineko. What were your plans about it? (I'd like, if possible, to drop even |
current status:
all in all, this PR is very big (look at the number of files and we're impacting (I also need to fix LHA, but I believe that should be not too complicated) |
I believe the unit test failing in #291 is protected here by Lines 216 to 218 in 7cf9e1b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also drop this?
Line 82 in 7cf9e1b
def ffns(cls, nf: int, mu2: SquaredScale): |
src/eko/evolution_operator/grid.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment: here all the q2_grid
are now evolgrid
.
Why? this is just an alternative constructor - which is handy at times ... (and there is no max nf business around - it just sets up correctly the thresholds ...) |
Closes #248
#291 is already big enough on it's own and I expect even more changes here, because we're breaking a lot of stuff so I decided for a PR on its own ...
I won't drop
n_integration_cores
for the moment, because we are still missing the replacement: the actual jets runner