Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new clm lake variables #77

Merged

Conversation

SamuelTrahanNOAA
Copy link

@SamuelTrahanNOAA SamuelTrahanNOAA commented Dec 1, 2022

Description of changes

This is part of a group of PRs that add the CLM Lake Model to ccpp-physics, fv3atm, and ufs-weather-model. The only changes in this PR are to update the mediator f90 and meta files to have the new variables needed to interface with ccpp-physics. The PRs are all drafts because the CLM Lake Model regression tests do not reproduce their control after a restart yet.

Specific notes

Contributors other than yourself, if any: none yet

CMEPS UFS Issues Fixed (include github issue #): ufs-community/ufs-weather-model#1510

Are changes expected to change answers? no

Any User Interface Changes (namelist or namelist defaults changes)? no

Testing performed

The tests performed were the ufs-weather-model regression tests. I don't know how to run any of these other tests, but the code changes are only in areas that CMEPS doesn't use in any configurations, and in fact it doesn't even have code to use it yet.

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

@SamuelTrahanNOAA SamuelTrahanNOAA marked this pull request as ready for review April 11, 2023 16:59
@zach1221
Copy link

Testing is finished on PR #1509, and we are ready to begin merge process. @DeniseWorthen @BrianCurtis-NOAA could you merge this PR?

@BrianCurtis-NOAA
Copy link
Collaborator

I do not have merge permissions here.

@jkbk2004
Copy link

All tests are done at ufs-community/ufs-weather-model#1509. This pr can be merged.

@DeniseWorthen DeniseWorthen merged commit fe2c158 into NOAA-EMC:emc/develop Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants