forked from ESCOMP/CMEPS
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new clm lake variables #77
Merged
DeniseWorthen
merged 4 commits into
NOAA-EMC:emc/develop
from
SamuelTrahanNOAA:clm_lake_revert.v9
Apr 26, 2023
Merged
new clm lake variables #77
DeniseWorthen
merged 4 commits into
NOAA-EMC:emc/develop
from
SamuelTrahanNOAA:clm_lake_revert.v9
Apr 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 tasks
tanyasmirnova
approved these changes
Dec 2, 2022
BrianCurtis-NOAA
approved these changes
Apr 11, 2023
tanyasmirnova
approved these changes
Apr 11, 2023
DeniseWorthen
approved these changes
Apr 11, 2023
Testing is finished on PR #1509, and we are ready to begin merge process. @DeniseWorthen @BrianCurtis-NOAA could you merge this PR? |
I do not have merge permissions here. |
All tests are done at ufs-community/ufs-weather-model#1509. This pr can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is part of a group of PRs that add the CLM Lake Model to ccpp-physics, fv3atm, and ufs-weather-model. The only changes in this PR are to update the mediator f90 and meta files to have the new variables needed to interface with ccpp-physics. The PRs are all drafts because the CLM Lake Model regression tests do not reproduce their control after a restart yet.
Specific notes
Contributors other than yourself, if any: none yet
CMEPSUFS Issues Fixed (include github issue #): ufs-community/ufs-weather-model#1510Are changes expected to change answers? no
Any User Interface Changes (namelist or namelist defaults changes)? no
Testing performed
The tests performed were the ufs-weather-model regression tests. I don't know how to run any of these other tests, but the code changes are only in areas that CMEPS doesn't use in any configurations, and in fact it doesn't even have code to use it yet.
Testing performed if application target is CESM:
Testing performed if application target is UFS-coupled:
Testing performed if application target is UFS-HAFS:
Hashes used for testing: