Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLM Lake Model and update Flake #1509

Merged
merged 180 commits into from
Apr 26, 2023

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented Dec 1, 2022

Description

This PR adds the CLM Lake Model, updates the Flake model, and adds an experimental feature to run both NSST and a lake model on lake points. The FV3_HRRR suite uses clm_lake by default, and the long-forgotten control_flake tests now exists.

Top of commit queue on: TBD

Input data additions/changes

  • There will be new input data.

HERA: /scratch2/BMC/wrfruc/Samuel.Trahan/lakes/RT/NEMSfv3gfs/input-data-20221101/lake_p8_water_fraction2020

Anticipated changes to regression tests:

  • Changes are expected to the following tests:

Only tests that have lake data and LKM=1 will change results. This is the list:

  • control_flake
  • hrrr_control
  • hrrr_control_decomp
  • hrrr_control_2threads
  • hrrr_control_restart
  • hrrr_control_debug
  • rap_clm_lake_debug
  • rap_flake_debug
  • hrrr_control_dyn32_phy32
  • hrrr_control_2threads_dyn32_phy32
  • hrrr_control_decomp_dyn32_phy32
  • hrrr_control_restart_dyn32_phy32
  • hrrr_control_debug_dyn32_phy32

To test this, I did the following for hera.intel and hera.gnu:

  1. Ran against the 20230407 baseline to get the list of tests that change.
  2. Copied the baseline data and replaced only the changed tests' baselines.
  3. Verified against that.

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

YihuaWu-NOAA and others added 30 commits August 8, 2022 14:18
setup RT for flake
update FV3 repository
…AA/ufs-weather-model into clm_lake_develop.v9
…elTrahanNOAA/ufs-weather-model into iterative_changes_clm_lake.v9
@jkbk2004
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: RT
[RT] Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/1142034258/20230425173015/ufs-weather-model
[RT] Error: Test control_flake 005 failed in run_test failed
Please make changes and add the following label back: hera-gnu-RT

@jkbk2004 jkbk2004 mentioned this pull request Apr 26, 2023
37 tasks
@zach1221
Copy link
Collaborator

We'll skip Gaea on this PR, so testing is finished and we can begin the merging process @SamuelTrahanNOAA .

@zach1221 zach1221 mentioned this pull request Apr 26, 2023
9 tasks
@DeniseWorthen
Copy link
Collaborator

CMEPS is ready fe2c158

@SamuelTrahanNOAA
Copy link
Collaborator Author

SamuelTrahanNOAA commented Apr 26, 2023

The FV3 and CMEPS submodules now point to their authoritative repos and hashes.

@zach1221
Copy link
Collaborator

I'll request final approval and then we should be able to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. hera-RT Run Hera regression testing jenkins-ci Jenkins CI: ORT build/test on docker container New Input Data Req'd This PR requires new data to be sync across platforms Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the CLM Lake Model and generate lake data on a regional grid.