Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for working with MPI from NCEPLIBS-external or elsewhere #34

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Feb 5, 2020

Update CMakeLists.txt:

  • can use MPI from NCEPLIBS-external or elsewhere
  • bugfix for WGRIB2 (need to set variable WGRIB2_ROOT)
  • additional variables written to the shell scripts that set the environment variables for compiling the UFS model

Also update .gitmodules to change the branch name for NCEPLIBS-post (aka EMC_post) to release/public-v4, see NOAA-EMC/UPP#64.

@climbfuji climbfuji changed the title Update for working with MPI from NCEPLIBS-external or elsewhere DO NOT MERGE YET - Update for working with MPI from NCEPLIBS-external or elsewhere Feb 5, 2020
@climbfuji climbfuji changed the base branch from master to release/public-v1 February 5, 2020 17:49
@climbfuji
Copy link
Collaborator Author

I tested this PR together with NOAA-EMC/NCEPLIBS-external#12 successfully for two different setups:

  • using gcc+gfortran with no MPI library installed, i.e. install it as part of NCEPLIBS-external
  • using clang+gfortran with MPI library installed, i.e. add -DBUILD_MPI=OFF to the NCEPLIBS-external build

@climbfuji
Copy link
Collaborator Author

This PR must be merged together with NOAA-EMC/NCEPLIBS-external#12

@climbfuji climbfuji marked this pull request as ready for review February 5, 2020 17:54
@climbfuji climbfuji changed the title DO NOT MERGE YET - Update for working with MPI from NCEPLIBS-external or elsewhere Update for working with MPI from NCEPLIBS-external or elsewhere Feb 5, 2020
@mark-a-potts mark-a-potts merged commit af0d602 into NOAA-EMC:release/public-v1 Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants