Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct total soil moisture from SOIMOI to CISOIM #922

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Correct total soil moisture from SOIMOI to CISOIM #922

merged 3 commits into from
Apr 9, 2024

Conversation

WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA WenMeng-NOAA commented Apr 8, 2024 •
edited
Loading

The main updates include:

  • Change the grib2 name of total soil moisture from SOILMOI into CISOILM.
  • Update CMake debug option to solve inline post failure at ufs-weather-model debug mode.

@WenMeng-NOAA WenMeng-NOAA added bug Something isn't working GFSV17 labels Apr 8, 2024
@WenMeng-NOAA WenMeng-NOAA linked an issue Apr 8, 2024 that may be closed by this pull request
Change grib2 name of total soil moisture #914
Closed
HuiyaChuang-NOAA
HuiyaChuang-NOAA approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@HuiyaChuang-NOAA HuiyaChuang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. Baseline Change The baselines of the UPP regression tests are changed. labels Apr 8, 2024
@WenMeng-NOAA WenMeng-NOAA linked an issue Apr 8, 2024 that may be closed by this pull request
The inline post failure at ufs-weather-model for debug mode #923
Closed
@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs were completed on WCOSS2 with baseline change for gfs.

@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. The expected changes are:

-rw-r--r-- 1 wen.meng emc 777 Apr  8 19:28 gfs.20190830/gfs.t00z.sfluxgrbf006.grib2.diff
-rw-r--r-- 1 wen.meng emc 777 Apr  8 19:40 gfs.20190830_pe_test/gfs.t00z.sfluxgrbf006.grib2.diff

The actual change is in metadata of gfs.t00z.sfluxgrbf006:

from 
  21:45715792:d=2019083000:SOILMOI:0-2 m below ground
into
  21:45715792:d=2019083000:CISOILM:0-2 m below ground

@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA You may refer to my testing at /home/Wen.Meng/stmp2/ on Hera:

Wen.Meng@hfe08 stmp2$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp  75 Apr  8 23:07 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp 417 Apr  8 23:15 gfs.20190830/gfs.t00z.sfluxgrbf006.grib2.diff
-rw-r--r-- 1 Wen.Meng stmp 417 Apr  8 23:16 gfs.20190830_pe_test/gfs.t00z.sfluxgrbf006.grib2.diff

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may refer to my testing at /home/Wen.Meng/stmp2/ on Hera:

Wen.Meng@hfe08 stmp2$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp  75 Apr  8 23:07 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp 417 Apr  8 23:15 gfs.20190830/gfs.t00z.sfluxgrbf006.grib2.diff
-rw-r--r-- 1 Wen.Meng stmp 417 Apr  8 23:16 gfs.20190830_pe_test/gfs.t00z.sfluxgrbf006.grib2.diff

Hera, Hercules, and Orion RTs match with your results on my side, thank you.

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 5faac75 into NOAA-EMC:develop Apr 9, 2024
5 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Apr 9, 2024
Closed
zhanglikate added a commit to zhanglikate/UPP that referenced this pull request Apr 30, 2024
@zhanglikate
Squashed commit of the following:
7cf2fe3 
commit 13d5b6d
Author: EricJames-NOAA <eric.james@noaa.gov>
Date:   Mon Apr 29 15:28:47 2024 -0600

    RRFS updates (NOAA-EMC#938)

    * Initial commit to rename RRFS fix files, update EBB to be vertically integrated from 3D ebu_smoke, and switch to use 1-h average HWP.

    * Getting rid of vertically integrated hydrometeor fields.

    * Updating postxconfig-NT-rrfs.txt

commit 88493f3
Author: Wei Huang <wei.huang@noaa.gov>
Date:   Fri Apr 26 21:29:51 2024 -0600

    add module for AWS (NOAA-EMC#934)

    * add module for AWS

    * comment that this is for NOAA Cloud

commit be0410e
Author: hsinmulin-NOAA <48441737+hsinmulin-NOAA@users.noreply.github.com>
Date:   Tue Apr 23 15:46:47 2024 -0400

    Add files via upload (NOAA-EMC#937)

    add
    1. 80 m for SPFH_ON_SPEC_HGT_LVL_ABOVE_GRND_FDHGT
    2. 80 m for PRES_ON_SPEC_HGT_LVL_ABOVE_GRND_FDHGT

commit 79d74d9
Author: Edward Hartnett <38856240+edwardhartnett@users.noreply.github.com>
Date:   Mon Apr 22 13:34:39 2024 -0600

    turn on doxygen build in CI (NOAA-EMC#932)

    * turn on doxygen build in CI

    * turn on doxygen build in CI

    * turn on doxygen build in CI

    * turn on doxygen build in CI

    * fixed cmake file

    * fixed doc directory

commit 5d6d179
Author: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
Date:   Fri Apr 19 14:17:10 2024 -0400

    Remove dependency on sfcio and use sigio only when nemsio is enabled (NOAA-EMC#930)

    * Remove sfcio and use sigio only when numsio is enabled

    * Remove sfcio from modulefiles/wcoss2.lua

    * Compile GFSPOSTSIG.F only if nemsio is enabled

commit 91921f4
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 21:04:39 2024 -0400

    Bump idna from 3.6 to 3.7 in /doc/UserGuide (NOAA-EMC#928)

    Bumps [idna](https://github.com/kjd/idna) from 3.6 to 3.7.
    - [Release notes](https://github.com/kjd/idna/releases)
    - [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst)
    - [Commits](kjd/idna@v3.6...v3.7)

    ---
    updated-dependencies:
    - dependency-name: idna
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Wen Meng <Wen.Meng@noaa.gov>

commit 8bc3fc9
Author: EricJames-NOAA <eric.james@noaa.gov>
Date:   Fri Apr 12 16:06:36 2024 -0600

    Bug fix for blowing snow effect on visibility (NOAA-EMC#915)

    * Correcting bug in CALVIS_GSD.f

    * Introducing roughness length impact on BLSN (no BLSN effect at z0>0.7).

    * Removing some gridpoint print statements for testing.

    * Checking change to compile_upp.sh

    * Reverting change.

commit fd93933
Author: YaliMao-NOAA <53870326+YaliMao-NOAA@users.noreply.github.com>
Date:   Thu Apr 11 17:14:24 2024 +0000

    For RRFS, change the mnemonics of column max of EDPARM from EDPARM on 0m level to MXEDPRM of the entire atmosphere. (NOAA-EMC#926)

    For this purpose, MXEDPRM is added to both post_avblflds.xml and control file fv3lam_rrfs.xml

commit 5faac75
Author: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com>
Date:   Tue Apr 9 18:25:18 2024 -0400

    Correct total soil moisture from SOIMOI to CISOIM (NOAA-EMC#922)

    * Correct total soil moisture from SOIMOI to CISOIM

    * Update shortname of UPP ID 36

    * update CMake debug mode

commit 83e83a9
Author: Innocent Souopgui <162634017+InnocentSouopgui-NOAA@users.noreply.github.com>
Date:   Fri Apr 5 15:10:14 2024 -0500

    Remove the detection of Jet/Centos7 nodes (NOAA-EMC#920)

    * Remove the detection of Jet/Centos7 nodes and removes the associated module file jet_c.lua

    * Update detect_machine.sh remove hera 12

    ---------

    Co-authored-by: Fernando Andrade - NOAA <121964418+FernandoAndrade-NOAA@users.noreply.github.com>

commit 1d1e58a
Author: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
Date:   Fri Apr 5 13:10:20 2024 -0400

    Add BUILD_WITH_NEMSIO build option to allow building UPP without nemsio (NOAA-EMC#911)

    * Add BUILD_WITH_NEMSIO build option to allow building UPP without nemsio

    * Specify w3emc and bacio as dependencies of nemsio library

    * Add compile_upp.sh option to build without nemsio (-n)

commit 7d39b5c
Author: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com>
Date:   Thu Apr 4 17:07:14 2024 -0400

    Add LTNG in PRSLEV dataset of RRFS (NOAA-EMC#918)

commit 62ecf8a
Author: AndrewBenjamin-NOAA <103067657+AndrewBenjamin-NOAA@users.noreply.github.com>
Date:   Thu Apr 4 14:50:08 2024 -0400

    RRFSv1.0 Product cleanup: removal of retired products from fv3lam_rrfs.xml (NOAA-EMC#909)

    * removed  <table_info>NCEP</table_info> for ULWRF to use the official WMO ID rather than the dupilcate NCEP local use ID

    * removed <table_info>NCEP</table_info> from REFZR, REFZI, BMIXL, and CNWAT to use WMO grib2 ids

    * removed <table_info>NCEP</table_info> from SNOWC, SFEXC, SSRUN, BGRUN, FRICV, CD, SNOHF, PEVAP, TCOLI in order to use WMO id over NCEP local use ID.

    * removed <table_info>NCEP<table_info> from SNFALB, CDLYR, USWRF, DSWRF, DLWRF, VWSH, TCOLR, TCOLS, UPHL

    * removed <table_info>NCEP<table_info> from MSTAV in post_avblflds.xml to use WMO grib2 id for RRFS

    * removed duplicate CNWAT NATLEV entry in fv3lam_rrfs.xml.

    * updated fv3lam_rrfs.xml and parm/postxconfig-NT-fv3lam_rrfs.txt to remove products no longer needed in the RRFS.

    * changed precision in SSRUN

    * fixed SSRUN precision in flat file

    * removed LSPA and SNOWC from NATLEV

commit df9b16b
Author: EricJames-NOAA <eric.james@noaa.gov>
Date:   Mon Apr 1 15:51:56 2024 -0600

    Add surface albedo, accumulated snow melt, and total soil moisture output in RRFS (NOAA-EMC#908)

    * Updating CLDRAD and INITPOST_NETCDF

    * Reverting change in CLDRAD.f

    * Changes to output CISOILM and SNOM.

    * Cleaning up syntax.

    * Adding change logs.

    * Small updates.

    * Removing extcof55 from visibility calculation (it's all zeroes).

    * Reverting change in INITPOST_NETCDF.f setting smstot to spval

    * Using a single level "0 m underground" for CISOILM

commit 92b080d
Author: KarinaAsmar-NOAA <148993962+KarinaAsmar-NOAA@users.noreply.github.com>
Date:   Sat Mar 30 20:03:49 2024 -0400

    Add additional SFS variables and isobaric levels (NOAA-EMC#903)

    * added additional isobaric levels

    * adding HLCY, SSRUN, VBDSF

    * added HLCY, SSRUN, VBDSF

    * replacing id 772 with 401 and 403 (vbdsf and nbdsf)

    * vbdsf and nbdsf with info from avblflds

    * removed id 772 and added 401 and 403 (vbdsf and nbdsf)

    * vbdsf and nbdsf copied from gfs flux

    * vbdsf and nbdsf copied from gfs flux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@HuiyaChuang-NOAA HuiyaChuang-NOAA HuiyaChuang-NOAA approved these changes

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

Assignees
No one assigned
Labels
Baseline Change The baselines of the UPP regression tests are changed. bug Something isn't working GFSV17 Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The inline post failure at ufs-weather-model for debug mode Change grib2 name of total soil moisture
4 participants
@WenMeng-NOAA @FernandoAndrade-NOAA @DusanJovic-NOAA @HuiyaChuang-NOAA