UKMO Staging [fb_rtd2, bf_coupling condition, bf_smc_omp] #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FB_rtd2: Output boundary conditions to rotated grids * This feature allows the user to specify the pole of each nested grid output of boundary conditions (nest) file. - There is no effect unless the switch RTD is set for compilation. - The contents of b.c. output files nestI.ww3 are not affected. - A model compiled with combined switches SMC and RTD is not affected. * Updated manual Sec. "3.4.9 Rotated grids" * Added regtests for testing input/output BCs in rotated pole context. * Updated revision of ww3_bound.ftn to 7.11 * Added new ww3_tr1 regtest (rotated pole) to matrix.base. Also, split the SMC/RTD regtests into their own separate switches. Co-authored-by: ukmo-chris.bunney <christopher.bunney@metoffice.gov.uk>
* Fixed allocation of FIELD variable. * Removed defunct OMPX switches and FLOMP variable
ukmo-ccbunney
added
bug
ukmo-ccbunney
added this to the 7.11: Specify output boundary conditions to rotated grids #68 milestone
aliabdolali
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
@ukmo-ccbunney I checked the staging on NCEP HPC and compared it with the development. Everything looks good and consistent with your comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
stagingbranch PR comprises the following 3 PRs in the UKMO repo:Each of the above PRs has been reviewed and relevant regtests have been run. See the individual links for more details.
A full regression test matrix output for the
stagingbranch is provided in the attached zip file:matrixCompFull_staging_20200923.zip
A summary of differences is provided below:
Known differences:
mww3_test_03: Known issue; not B4B.ww3_ta1andww3_ts1: Known issue where some ST4 based tests are not B4B (see ST4 b4b reproduciblity issue #249)ww3_tp2.18: Known issue inww3_prtide_current.out_diff.txt(order of screen output random when running MPI; see Regtest tp2.18: ww3_prtide_current screen output not reproducible with MPI #225)Expected differences:
ww3_tp2.11: Extra output inww3_grid.outshowing the new rotated pole locations (Fb rtd2 ukmo-waves/WW3#7)ww3_tr1: New regression test Fb rtd2 ukmo-waves/WW3#7