-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aradhakrishnan/add analysis #1
Aradhakrishnan/add analysis #1
Conversation
…may/maynot be recognized. so adding mkdir out_dir before copy
Conflicts: README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the links to the python notebooks to relative links. That will keep from getting a 404 error when looking for the notebook pages. Also, allows users to view the notebook on the same branch as the README.md the user is reviewing.
README.md
Outdated
|
||
E.g. | ||
|
||
* [Radiation processor](https://github.com/NOAA-GFDL/AM4/blob/master/analysis/cjs1/radiation_atmos_av_mon/radiation_atmos_av_mon.ipynb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use relative links to the files in the repository, and not full URLs. This way, github can use the branch you are on to show that specific version of the file. As it is now, when you click the link you will get a 404 error.
* [Radiation processor](analysis/cjs1/radiation_atmos_av_mon/radiation_atmos_av_mon.ipynb)
* [Long-term DJF seasonal mean](analysis/bw/bw_atmos_cru_ts_a1r/bw_atmos_monthly_cru_ts.1980-2014.ipynb)
* [Zonal_mean_zonal_wind_stress](analysis/bw/bw_atmos_zm_atl_pac_a1r/bw_atmos_atl_pac.1980-2014.ipynb)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@underwoo Done. Available for your review. Thanks,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@underwoo Please find the new changes with relative links. Thanks,
AM4 Analysis/jupyter notebooks for 3 analysis suites have been added with an update to README.md.