Added editorconfig file to repository #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngs333
reviewed
Dec 16, 2020
There was a problem hiding this comment.
I've tested with the proposed .editorconfig with emacs and with VS Code, and with emacs
I've encountered some problems. For example, one can do a format selection of the last function (compress_int_data) in the c file /tools/remap_land/remap_land.c. If the last line (indent_style = 1) in .editorconfig is commented out, emacs indents compress_int_data with two spaces per indent (which I think is the intended result), but if the last line is left intact, then emacs indents the function with one space per indent.
|
Looks like a |
A missing newline kept the Makefile configs from applying to only the Makefiles. This corrects that.
|
@ngs333, please test again with the latest update. |
ngs333
approved these changes
Dec 17, 2020
|
@underwoo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an .editorconfig file with the initial editor configuration we would like to see in the FMS project. Information at https://editorconfig.org on how to configure specific editors to use the information contained in this file.
fixes #31