-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ProcessHeat load, separate DHW and SpaceHeating loads #356
Conversation
Following up on our discussion this week, this is changed to fuel loads instead of heat in 14abae0 |
@Bill-Becker this should be ready for your review again. For some reason I'm not seeing your original review, but here are the key responses:
I'm running Xpress tests locally now and will update as needed if any tests are still broken after merging develop into this branch. Should I add the Process Heat test suite to the test_with_xpress.jl in parallel? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying and addressing my requests! I updated passing the user input boiler efficiency into ProcessHeat instead of always EXISTING_BOILER_EFFICIENCY, and I'm bypassing the Ubuntu tests until we can figure out why that one test is taking so long to solve that GitHub cancels the operation.
Add ProcessHeat load, separate DHW and SpaceHeating loads
Added
src/core/absorption_chiller.jl
struct, added field heating_load_input to the AbsorptionChiller structp.heating_loads
and added reconciliation constraints so that dvProductionToStorage and dvDischargeFromStorage maintain their relationship to state of charge for Hot thermal energy storage.src/core/techs.jl
, added new sets ghp_techs, cooling_techs, techs_can_serve_space_heating, techs_can_serve_dhw, and techs_can_serve_process_heatsrc/core/reopt_inputs.jl
, added new fields heating_loads, heating_loads_kw, heating_loads_served_by_tes, and absorption_chillers_using_heating_load to the REoptInputs and BAUInputs structs. in the math, new setp.heating_loads
has index q (to represent "qualities" of heat).src/core/heating_cooling_loads.jl
, added new struct ProcessHeatLoadsrc/core/scenario.jl
, added new field process_heat_loadsrc/mpc/inputs.jl
, added new field heating_loadsChanged
p.heating_loads
p.heating_loads
Fixed
src/constraints/steam_turbine_constraints.jl
that allows for heat loads to reconcile when thermal storage is paired with a SteamTurbine.