-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pv prod fix #326
Pv prod fix #326
Conversation
PVWatts v6 uses 1.2 default (this is also the default in nested_inputs)
were previously overwriting user-entered azimuth value for ground-mount systems in southern hemisphere. Now only overwritten if 180. Were previously not setting azimuth to 0 for roofmount systems. Now we are if azimuth =180
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments to address but looks good!
Can we combine your new test with this old one:
https://github.com/NREL/REopt_API/blob/master/reo/tests/test_southern_hemisphere_latitude.py
?
Combining the two would make one less API post/optimization in the test suite.
Combined these tests here! 9eb58aa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge if tests pass. We can also merge this into master after testing the develop deploy and merge to staging/production thereafter.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
src/pvwatts.py
, Updated lat-long coordinates if-statement used to determine whether the "nsrdb" dataset should be used to determine the PV prod factor. Accounts for recent updates to NSRDB data used by PVWatts (v6)What is the current behavior?
(You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
See changes
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Yes? More accurate PV data will be used for international evaluations.
Other information:
These are the bounds that are now applied to the NSRDB query: