endpoints edits for v3 #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
These should cover all load_type variables
By calling /dev/sim... which calls the http.jl endpoint, we include testing of type parsing and conversions that django does before calling http.jl endpoint
/simulated_load endpoint returns the annual_kwh and uses the Julia functions from http.jl so it's more in sync with REopt.jl
Bill-Becker
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
@indu-manogaran I added some type-conversion code which replaced some of the stuff you added, but this should handle all load_types (heating and cooling too).
Also, I removed the /annual_kwh endpoint from reoviews because you can instead use the /simulated_load endpoint to get annual_kwh. That endpoint was still calling the python commercial reference building code anyway, so it would become out-of-sync eventually.
|
Thanks, Bill. I'll update the UI code to reflect the removal of /annual_kwh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit endpoints to create a working v3 version