Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELM-based ordinance retrieval and extraction #13

Merged
merged 170 commits into from
May 1, 2024
Merged

ELM-based ordinance retrieval and extraction #13

merged 170 commits into from
May 1, 2024

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Mar 27, 2024

Add code to support ELM paper.

Notes

  • Tests break main ELM and ELM-ordinances up into separate pieces. This ensures base ELM can still be installed with no hassle.
  • Bumped Python version to 3.9 (max at 3.11)
  • Bumped ELM version to 0.0.4

@ppinchuk ppinchuk marked this pull request as ready for review March 27, 2024 20:57
Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two additional comments and i'm not sure where they go:

  1. While running ords, we get an error: AttributeError: None of the edge conditions from "init" were satisfied: [{'condition': <function llm_response_starts_with_yes at 0x12369cc10>}]

Maybe should say “This is not necessarily an error and may mean that the text does not have the requested data”

  1. Could we download the pdf’s to a subdir similar to how the logs are stored?

examples/ordinance_gpt/README.rst Show resolved Hide resolved
elm/ords/README.md Outdated Show resolved Hide resolved
elm/ords/README.md Outdated Show resolved Hide resolved
with open(fp, "w") as fh:
json.dump(usage_info, fh, indent=4)

logger.info("Total processing time: %s", total_time_str)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we could add an additional log message somewhere around here stating "{} ordinances found for {county} {state}. Outputs are here: {}"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Added this and also a message if no ordinance values are found at all.

@ppinchuk
Copy link
Collaborator Author

Two additional comments and i'm not sure where they go:

  1. While running ords, we get an error: AttributeError: None of the edge conditions from "init" were satisfied: [{'condition': <function llm_response_starts_with_yes at 0x12369cc10>}]

Maybe should say “This is not necessarily an error and may mean that the text does not have the requested data”

  1. Could we download the pdf’s to a subdir similar to how the logs are stored?

Yup! Added both.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ppinchuk ppinchuk merged commit 42e9ed6 into main May 1, 2024
10 checks passed
@ppinchuk ppinchuk deleted the pp/ords branch May 1, 2024 18:39
github-actions bot pushed a commit that referenced this pull request May 1, 2024
ELM-based ordinance retrieval and extraction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants