Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gb/ord example #24

Merged
merged 18 commits into from
Jul 10, 2024
Merged

Gb/ord example #24

merged 18 commits into from
Jul 10, 2024

Conversation

grantbuster
Copy link
Member

No description provided.

@grantbuster grantbuster requested a review from ppinchuk July 9, 2024 19:55
@grantbuster
Copy link
Member Author

@ppinchuk here's a PR that makes the paper revision a little better. I'll ping you with more details about the paper.

Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, looks great man.

It looks like after getting past the initial barrier to entry, setting up the parsing didn't end up being too difficult. Is this actually true, or would you say it was still troublesome?

More generally I'd love to hear your honest feedback on the usability of these functions if you have free time at some point (trying to continue improving wherever I can!). I know you mentioned that code should be self-documenting and modular, and I do think I tried to adhere to that as much as I could (obviously the services architecture needs a user guide that I didn't include during the first pass), but I'd love to hear if there is anything else you disliked when working with the code that you haven't mentioned yet.

But only if you haver the time and desire :)

elm/ords/README.md Outdated Show resolved Hide resolved
elm/ords/process.py Show resolved Hide resolved
elm/pdf.py Outdated Show resolved Hide resolved
elm/pdf.py Outdated Show resolved Hide resolved
elm/pdf.py Outdated Show resolved Hide resolved
examples/ordinance_gpt/parse_pdf.py Outdated Show resolved Hide resolved
grantbuster and others added 5 commits July 10, 2024 15:08
Co-authored-by: Paul Pinchuk <ppinchuk@physics.ucla.edu>
Co-authored-by: Paul Pinchuk <ppinchuk@physics.ucla.edu>
Co-authored-by: Paul Pinchuk <ppinchuk@physics.ucla.edu>
Co-authored-by: Paul Pinchuk <ppinchuk@physics.ucla.edu>
@grantbuster grantbuster merged commit 1c9cf0d into main Jul 10, 2024
12 checks passed
@grantbuster grantbuster deleted the gb/ord_example branch July 10, 2024 21:25
github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants