Bugfix: using the wrong rotor diameters when plotting with the CC model #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This bugfix corrects the rotor diameters that are being used when plotting the CC model. Currently, plotting with the CC model results in a code error. It also corrects the
crossstream_distvalue in the02_visualizations.pyexample.Related issue, if one exists
None.
Impacted areas of the software
solver.pyAdditional supporting information
This bug was introduced in pull #381, on line 558 of
simulation/solver.py.Test results, if applicable
Running example
02_visualizations.pywith thecc.yamlinput file produces: