Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReEDS representative profiles appear to not be in local time #51

Closed
mmowers opened this issue Mar 9, 2020 · 4 comments
Closed

ReEDS representative profiles appear to not be in local time #51

mmowers opened this issue Mar 9, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@mmowers
Copy link
Collaborator

mmowers commented Mar 9, 2020

Bug Description
It appears that the representative profile outputs for ReEDS may not be shifted to local time (assuming the input profiles are in UTC).

To Reproduce
Compare the 'rep_profiles_0' tables of these two files:

  • input: /shared-projects/rev/projects/reeds_jan2020/wind/ reeds_wind_rep_profiles_2012.h5
  • output: /shared-projects/rev/projects/reeds_jan2020/wind/onshore_wind/output/windons_hourly_cf.h5

Specifically, compare the profile for sc_id 2726 (column 2726) in the input table to its corresponding entry in the output table (it is the representative profile for region 1 class 8, or column 4 of the output table). The comparison looks like:
image

Notice that, other than being scaled by 1000, the output has only shifted by -1 as compared to the input (correctly accounting for our requirement to start the arrays at 1am), while the timezone correction should be an additional shift of -8.

Expected behavior
Representative profiles are shifted to local time.

@mmowers mmowers added the bug Something isn't working label Mar 9, 2020
@MRossol
Copy link
Collaborator

MRossol commented Mar 9, 2020

We only made timeslices in local time, will re-implement that in profiles

@MRossol
Copy link
Collaborator

MRossol commented Mar 10, 2020

@mmowers This should also be fixed in the most recent runs on eagle (I've replaced the data in */output/).

Can you check and close this if it's fixed, waiting on @grantbuster to approve the PR #52

@mmowers
Copy link
Collaborator Author

mmowers commented Mar 11, 2020

Hi @MRossol , I can't access the new output/ folder. could you open up permissions?

@mmowers
Copy link
Collaborator Author

mmowers commented Mar 12, 2020

Looks good now! I spot checked sc_id 2726 and a few others, and they have been shifted to local. Closing this issue.

@mmowers mmowers closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants