Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReEDS Profiles to local time #52

Merged
merged 6 commits into from
Mar 10, 2020
Merged

ReEDS Profiles to local time #52

merged 6 commits into from
Mar 10, 2020

Conversation

MRossol
Copy link
Collaborator

@MRossol MRossol commented Mar 10, 2020

Move UTC to Local Time shift from timeslices to Profiles
Update Tests
Fix PR workflow
Add package to Outputs

@MRossol
move local time shift to profiles
95f30ab 
update tests
add package to outputs
@MRossol MRossol added bug Something isn't working feature New feature or request labels Mar 10, 2020
@MRossol MRossol mentioned this pull request Mar 10, 2020
Closed
grantbuster
grantbuster requested changes Mar 10, 2020
View reviewed changes
Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you just do a ctrl+f of "timezone" in reeds_timeslices.py and clean up comments? There's also a tz variable that doesn't get used.

@MRossol MRossol merged commit 5e40ce7 into master Mar 10, 2020
@MRossol MRossol deleted the reeds_localtime branch March 10, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantbuster grantbuster grantbuster approved these changes

Assignees
No one assigned
Labels
bug Something isn't working feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MRossol @grantbuster