Gb/pagg missing gids #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are missing resource gids
…, when the bad capacity is added to the good capacity, the += index method didn't property add the data. Put in a for loop. Works. Added test.
grantbuster
force-pushed
the
gb/pagg_missing_gids
branch
from
de595c3
to
ce52a3f
Compare
MRossol
reviewed
Oct 29, 2019
MRossol
previously approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in plexos aggregation where if the CF file was missing res gids it would try and allocate that buildout to valid gids, but it wasnt working perfectly. I found the bug and added a test. All good now. Will tell greg (minor effect in the most recent naris data).
bug fix was weird pandas += behavior: 3075efc