Gb/rpm h5 excl #19
Gb/rpm h5 excl #19
Conversation
| @@ -349,7 +348,7 @@ def _dist_rank_filter(self, iterate=True, **kwargs): | |||
| c_centroids = clusters.cluster_coordinates | |||
| dist_i = np.linalg.norm(c_centroids - centroids) | |||
| rmse_i = np.mean((c_coeffs - coeffs) ** 2) ** 0.5 | |||
| if (dist_i < dist and rmse_i < rmse): | |||
| if (dist_i <= dist and rmse_i <= rmse): | |||
There was a problem hiding this comment.
@MRossol, FYI this was giving me a ton of trouble in my test cases. I'm not 100% sure how this works but dist_i and rmse_i were both 0 in the first iteration so the while loop hung indefinitely. Making these statements <= worked. I suspect the issue is something to do with the tiny domain.
There was a problem hiding this comment.
Hmm, that is strange but seems like a simple fix.
| @@ -349,7 +348,7 @@ def _dist_rank_filter(self, iterate=True, **kwargs): | |||
| c_centroids = clusters.cluster_coordinates | |||
| dist_i = np.linalg.norm(c_centroids - centroids) | |||
| rmse_i = np.mean((c_coeffs - coeffs) ** 2) ** 0.5 | |||
| if (dist_i < dist and rmse_i < rmse): | |||
| if (dist_i <= dist and rmse_i <= rmse): | |||
There was a problem hiding this comment.
Hmm, that is strange but seems like a simple fix.
reVX/rpm/rpm_output.py
Outdated
| @@ -715,9 +724,11 @@ def _single_excl(cluster_id, clusters, excl_fpath, techmap_fpath, | |||
| n_inclusions = np.zeros((len(locs), ), dtype=np.float32) | |||
| n_points = np.zeros((len(locs), ), dtype=np.uint16) | |||
|
|
|||
| techmap = RPMOutput._get_tm_data(techmap_fpath, techmap_dset, | |||
| excl = ExclusionMask.from_dict(excl_fpath, excl_dict) | |||
There was a problem hiding this comment.
It would be more pythonic and safer to run this as a with so the context manager will properly close the file in case anything goes wrong
|
@MRossol, two commits to deal with the github actions yml and the exclusions context manager. |
…techmap fpath input arg and replaced with exclusions dict.
…baseline validation.
grantbuster
force-pushed
the
gb/rpm_h5_excl
branch
from
880fda5
to
db5ace2
Compare
Refactor of RPM outputs handler with h5 exclusions. Added basic RPM baseline validation tests.