Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gb/reeds config #21

Merged
merged 10 commits into from
Dec 11, 2019
Merged

Gb/reeds config #21

merged 10 commits into from
Dec 11, 2019

Conversation

grantbuster
Copy link
Member

Added REEDS config module. Cleaned up cli and added Eagle submission methods (from config).

@grantbuster
Copy link
Member Author

@MRossol, just force pushed. Nasty rebase. Looks okay though.

Copy link
Collaborator

@MRossol MRossol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, let me know if I should re-review after timeslice updates

@grantbuster
Copy link
Member Author

There will be minor changes. I'll confirm merge once I test on Eagle.


ctx.obj['PROFILES'] = out_path


@classify.command()
@click.option('--profiles', '-pr', type=STR, default=None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use STR type instead of click.Path(exisits=True)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the cmd str gives it a none value.

@grantbuster grantbuster merged commit 33aaf71 into reeds Dec 11, 2019
@grantbuster grantbuster deleted the gb/reeds_config branch December 11, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants