-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gb/reeds config #21
Gb/reeds config #21
Conversation
4ab5e8e
to
6d1bcd3
Compare
@MRossol, just force pushed. Nasty rebase. Looks okay though. |
6d1bcd3
to
19c045c
Compare
19c045c
to
93371f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, let me know if I should re-review after timeslice updates
There will be minor changes. I'll confirm merge once I test on Eagle. |
|
||
ctx.obj['PROFILES'] = out_path | ||
|
||
|
||
@classify.command() | ||
@click.option('--profiles', '-pr', type=STR, default=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use STR type instead of click.Path(exisits=True)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the cmd str gives it a none value.
Added REEDS config module. Cleaned up cli and added Eagle submission methods (from config).