-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Offshore and Onshore Wind for Reeds (#27) #28
Conversation
6bdbc85
to
a4492e0
Compare
add split_offshore option to cli
add filter to classification
ee96969
to
bb3f33c
Compare
@grantbuster do you mind reviewing this before I merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some advice on a json loads issue that I ran into with the reV CLI's. Formatting dict strings for CLI's is so difficult... I've tried json.dumps() before but click had issues with the format. I left a comment with the best method I found.
reVX/reeds/reeds_cli.py
Outdated
cluster_kwargs=kwargs) | ||
table_full, table, agg_table = out | ||
cluster_kwargs=kwargs, | ||
filter=json.loads(filter)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI you might need to do something like i did in the link below. Basically if there is a stringified dict "{col: False}" you need to replace "False" with "false" and "None" with "null" for json loads to work properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converted this into a utility function here and added it to the reeds_cli
NREL/reV#108
""" | ||
rev_table = self._parse_table(rev_table) | ||
if filter is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
Implementation of #27: