Wind set backs #69
Wind set backs #69
Conversation
add test files
add earthpy to requirements
reVX/wind_setbacks/wind_setbacks.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| features_dir : str |
There was a problem hiding this comment.
great doc strings but incorrect description. probably elsewhere too.
What kind of files should these be? What extension does the code look for?
| replace=replace) | ||
|
|
||
|
|
||
| class RailWindSetbacks(TransmissionWindSetbacks): |
There was a problem hiding this comment.
why are rail setbacks based on transmission while the others are not? Is it that you can't build turbines within x distance of structures and roads, but you can't build transmission lines within x distance of railways? If so, how are we going to use the rail wind setbacks for our non-existent transmission code? Or is this a grue problem?
reVX/wind_setbacks/wind_setbacks.py
Outdated
| Raster array of setbacks, ready to be written to the exclusions | ||
| .h5 file as a new exclusion layer | ||
| """ | ||
| setbacks = super().compute_setbacks(structure_fpath, groupby='State', |
There was a problem hiding this comment.
I'm of the opinion that subclass methods that only call the inherited method via super() with a kwarg change should not be subclass methods. It's just not worth the extra code due to additional complexity and maintenance. Why not remove this subclass method and call BaseWindSetbacks.compute_setbacks() with the kwarg in the subclass.run() methods?
reVX/wind_setbacks/wind_setbacks.py
Outdated
| Parameters | ||
| ---------- | ||
| excl_h5 : str | ||
| Path to .h5 file containing or to contain exclusion layers |
There was a problem hiding this comment.
This is where the new setbacks will be written? This is not a source file, correct? If it is a source file, what is being used from it?
reVX/wind_setbacks/wind_setbacks.py
Outdated
| setbacks, by default None | ||
| multiplier : int | float | str | None, optional | ||
| setback multiplier to use if wind regulations are not supplied, | ||
| if str, must one of {'high': 3, 'moderate': 1.1}, |
There was a problem hiding this comment.
if str must be one of those keys? Kind of unclear. Maybe say that if str must be a key in cls.MULTIPLIERS?
Also what is the multiplier used for? I think based on our conversations and my fuzzy memory that this multiplies the max blade tip height to determine the setback, but that would be worthwhile to include in this description.
| .format(cnty.iloc[0]['FIPS'])) | ||
| tmp = gpd.sjoin(features, cnty, | ||
| how='inner', op='intersects') | ||
| tmp['geometry'] = tmp.buffer(setback) |
There was a problem hiding this comment.
ah this is where the magic happens! sweet.
| .h5 file as a new exclusion layer | ||
| """ | ||
| if max_workers is None: | ||
| max_workers = os.cpu_count() |
There was a problem hiding this comment.
if you just do if max_workers == 1: serial else: parallel and send max_workers to the process pool directly with None/int you don't need to retrieve the os.cpu_count(). Obviously you can't do max_workers > 1 if max_workers is None but you can do max_workers == 1 if max_workers is None, Yay dynamic typing!
| if regs_fpath: | ||
| if multiplier: | ||
| msg = ('A wind regulation .csv file was also provided and ' | ||
| 'will be used to determine setback multipliers!') |
There was a problem hiding this comment.
while this is clear in the source code, it would not be clear to a user what the csv was provided in addition to (the multiplier).
reVX/wind_setbacks/wind_setbacks.py
Outdated
| """ | ||
| trans = gpd.read_file(transmission_fpath) | ||
| mask = (~(trans['Proposed'] == 'Proposed') | ||
| & ~(trans['Undergroun'] == 'T')) |
There was a problem hiding this comment.
Undergroun a typo? (missing the d)
Also this is a super weird mask. Why not use != instead of ~==?
reVX/wind_setbacks/wind_setbacks.py
Outdated
|
|
||
| class TransmissionWindSetbacks(BaseWindSetbacks): | ||
| """ | ||
| Transmission Wind setbacks |
There was a problem hiding this comment.
without having to do a code diff can you explain how/why some of these transmission setbacks and methods are different than the structure setbacks?
Implementation of #65
TODO:
CLI
tests