Mnr/resource #7
Mnr/resource #7
Conversation
wtk and nsrdb -> resrouce
Implement multi-inheritence
reVX/resource/resource.py
Outdated
| site_df = pd.DataFrame(columns=gid, index=self.time_index) | ||
| site_df.name = ds_name | ||
| site_df.index.name = 'time_index' | ||
| site_df.loc[:, :] = self[ds_name, :, gid] |
There was a problem hiding this comment.
For all instances of .loc[:, :], would it be cleaner to initialize the dataframe as df = pd.DataFrame(self[ds_name, :, gid], columns=gid, index=self.time_index)?
There was a problem hiding this comment.
Good call. this was a lazy change.
| @main.command() | ||
| @click.option('--dataset', '-d', type=str, required=True, | ||
| help='Dataset to extract') | ||
| @click.option('--lat_lon', '-ll', nargs=2, type=click.Tuple([float, float]), |
There was a problem hiding this comment.
Is site data extraction only for lat/lon and never used to retrieve a single GID or list of GIDs? If lat/lon is fast enough i guess we don't need GID extraction, but it could be useful?
There was a problem hiding this comment.
gid options added to site and SAM
reVX/resource/resource_cli.py
Outdated
| @click.option('--region', '-r', type=str, default=None, | ||
| help='Region to extract') | ||
| @click.pass_context | ||
| def map(ctx, timestep, dataset, region_col, region): |
There was a problem hiding this comment.
map is a python special word. This might not cause issues, but maybe it will?
There was a problem hiding this comment.
changed to timestep to be safe
reVX/resource/resource.py
Outdated
|
|
||
| return tree | ||
|
|
||
| def _init_tree(self, tree=None): |
There was a problem hiding this comment.
Could we add a special method to force the explicit creation of a ckdtree from the meta data? This could be useful for special resource files (Puerto Rico NSRDB, which still has the nsrdb_ filename prefix).
There was a problem hiding this comment.
added compute_tree kwarg to WindX, SolarX, and NSRDBX
update setup.py
add compute_tree to wind and solar clis
TODO: Tests and final tests, but so far all works and want to get your eyes on this when/if you have some downtime